-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix array_map's error result when inputs are constant #51833
Merged
silverbullet233
merged 3 commits into
StarRocks:main
from
silverbullet233:fix_array_map
Oct 14, 2024
Merged
[BugFix] fix array_map's error result when inputs are constant #51833
silverbullet233
merged 3 commits into
StarRocks:main
from
silverbullet233:fix_array_map
Oct 14, 2024
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverbullet233
changed the title
[BugFix] fix array_map's error result when inputs are constant
[BugFix][UT] fix array_map's error result when inputs are constant
Oct 12, 2024
silverbullet233
changed the title
[BugFix][UT] fix array_map's error result when inputs are constant
[BugFix] fix array_map's error result when inputs are constant
Oct 12, 2024
silverbullet233
force-pushed
the
fix_array_map
branch
from
October 12, 2024 06:49
8fdbdde
to
e743723
Compare
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
fix_array_map
branch
from
October 12, 2024 13:24
c524874
to
39df0a0
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 8 / 8 (100.00%) file detail
|
LiShuMing
approved these changes
Oct 14, 2024
satanson
approved these changes
Oct 14, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 48db7f5)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 48db7f5)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ort #51833) (#51876) Co-authored-by: eyes_on_me <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ort #51833) (#51877) Co-authored-by: eyes_on_me <[email protected]>
@mergify backport branch-3.3.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 48db7f5)
42 tasks
silverbullet233
added a commit
that referenced
this pull request
Oct 15, 2024
…ort #51833) (#51942) Co-authored-by: eyes_on_me <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/8662
introduced by: #51244
for scenarios where all inputs are constant, we will directly evaluate lambda expr based on the const column to avoid extra overhead. In this case, we will not unpack the const column or align the offset with capture columns.
However, there is an exception, such as
array_map(x->array_length(x) > c1+1, [[1,2,3]])
, where the lambda expression depends on other capture columns. In this case, we cannot follow the above strategy and still need to unpack the const and follow the normal process, otherwise it will get a wrong result.in this pr, I fixed it.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: